-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoRA] make set_adapters()
robust on silent failures.
#9618
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@unittest.skip("Not supported in CogVideoX.") | ||
def test_simple_inference_with_text_denoiser_multi_adapter_block_lora(self): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're catching the error appropriately within the code, we should skip this test for unsupported models.
@@ -162,6 +162,10 @@ def test_simple_inference_with_text_denoiser_block_scale_for_all_dict_options(se | |||
def test_modify_padding_mode(self): | |||
pass | |||
|
|||
@unittest.skip("Not supported in Flux.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -111,6 +112,10 @@ def tearDown(self): | |||
gc.collect() | |||
torch.cuda.empty_cache() | |||
|
|||
@is_flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's absolutely no reason for it to be flaky but I think okay for now.
@@ -108,3 +114,7 @@ def test_simple_inference_with_text_denoiser_block_scale_for_all_dict_options(se | |||
@unittest.skip("Not supported in SD3.") | |||
def test_modify_padding_mode(self): | |||
pass | |||
|
|||
@is_flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #9618 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to check this, LGTM. I have some suggestions for the test, please check if they make sense.
Apart from that, I'm wondering if we still need the checks starting here:
Or are those now covered by the newly introduced check and can be removed?
@BenjaminBossan thanks!
Good catch. Resolved in 2714043. |
@DN6 could you give this a look? |
@DN6 a gentle ping. |
What does this PR do?
Currently, if we do
where
pipe
is an instance of theFluxPipeline
it doesn't error out whereas it should because Flux doesn't have any UNet and itstext_encoder_2
component isn't LoRA-loadable:diffusers/src/diffusers/loaders/lora_pipeline.py
Line 1650 in 31058cd
Instead, we silently ignore things. This PR fixes this behavior.
Thanks to @asomoza for the idea in #9542 (comment)!